You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR Author: Be sure to create and publish a GitHub Release pointing to trunk once this PR gets merged,
copy/pasting the following text as the GitHub Release's description:
### Bug Fixes
- `create_github_release` no longer crashes with `FrozenError` when the optional `release_notes_file_path` is omitted. [#759]
Mmmh I see we need to update the Danger wording about reviewers 😅 Will do that in follow-up PR.
Does that mean I don't actually manually have to ask for a review for these? I keep getting confused about this. GitHub shows codeowners are already assigned, but Danger specifically tells me they are not and I should assign manually, so it's what I do. (even though it feels like the wrong thing to do)
Ah, you already answered that here which I saw after posting the above comment. There is also a new PR which will hopefully improve the situation. So, disregard my previous question.
GitHub shows codeowners are already assigned, but Danger specifically tells me they are not and I should assign manually,
Yep I think this surfaced that we might have a bug in our github_utils.requested_reviewers? Dangermattic helper after all. Surfaced here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releasing new version 14.11.1.
What's Next
PR Author: Be sure to create and publish a GitHub Release pointing to
trunkonce this PR gets merged,copy/pasting the following text as the GitHub Release's description: